-
Notifications
You must be signed in to change notification settings - Fork 43
EDU-1469: Re-writes idempotent publishing section to improve clarity #2160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDU-1469: Re-writes idempotent publishing section to improve clarity #2160
Conversation
6f48047
to
0089403
Compare
I'm adding the REST code to this too |
4b1ce47
to
6f66dcc
Compare
d6b142f
to
5ad8e5d
Compare
285e554
to
4bfa4c0
Compare
4bfa4c0
to
2c7beb4
Compare
02e9a5d
to
96ee205
Compare
Is there a plan to finish/merge this? |
96ee205
to
7c6fb5d
Compare
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Oops, this was my bad. I split up all the channels section and forgot to go back and sort this out. I've rebased and updated @franrob-projects |
7c6fb5d
to
7695c22
Compare
This PR:
idempotentRestPublishing
istrue
on current APIs for REST and realtime SDKs (except on older libraries with API version < 1.2).EDU-1469: Idempotent publishing doesn't describe idempotent realtime publishing