Skip to content

EDU-1469: Re-writes idempotent publishing section to improve clarity #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

franrob-projects
Copy link
Contributor

This PR:

  • Re-writes idempotent publishing section to improve clarity
  • Improves the general narrative of the article.
  • Clarifies that idempotentRestPublishing is true on current APIs for REST and realtime SDKs (except on older libraries with API version < 1.2).

EDU-1469: Idempotent publishing doesn't describe idempotent realtime publishing

@ably-ci ably-ci temporarily deployed to ably-docs-edu-1469-idem-yh53ug March 14, 2024 17:29 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-yh53ug March 18, 2024 15:06 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-yh53ug March 18, 2024 15:20 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-yh53ug March 18, 2024 15:35 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-yh53ug March 18, 2024 15:41 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-yh53ug March 18, 2024 15:46 Inactive
@franrob-projects franrob-projects force-pushed the EDU-1469-Idempotent-publishing-doesnt-describe-idempotent-realtime-publishing branch from 6f48047 to 0089403 Compare March 18, 2024 15:57
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-yh53ug March 18, 2024 15:57 Inactive
@franrob-projects
Copy link
Contributor Author

I'm adding the REST code to this too

@franrob-projects franrob-projects force-pushed the EDU-1469-Idempotent-publishing-doesnt-describe-idempotent-realtime-publishing branch from 4b1ce47 to 6f66dcc Compare April 4, 2024 10:10
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-5ctusc May 3, 2024 13:04 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-zjwbxj June 12, 2024 10:25 Inactive
@m-hulbert m-hulbert marked this pull request as draft July 5, 2024 08:10
@franrob-projects franrob-projects force-pushed the EDU-1469-Idempotent-publishing-doesnt-describe-idempotent-realtime-publishing branch from d6b142f to 5ad8e5d Compare July 31, 2024 07:30
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-ad6qfq July 31, 2024 15:56 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-ad6qfq August 1, 2024 11:26 Inactive
@franrob-projects franrob-projects force-pushed the EDU-1469-Idempotent-publishing-doesnt-describe-idempotent-realtime-publishing branch from 285e554 to 4bfa4c0 Compare August 1, 2024 11:28
@franrob-projects franrob-projects marked this pull request as ready for review August 1, 2024 11:28
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-ad6qfq August 1, 2024 11:28 Inactive
@m-hulbert m-hulbert temporarily deployed to ably-docs-edu-1469-idem-ra8k9p August 21, 2024 15:25 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-d16zeb August 28, 2024 10:03 Inactive
@m-hulbert m-hulbert marked this pull request as draft September 18, 2024 10:35
@franrob-projects franrob-projects force-pushed the EDU-1469-Idempotent-publishing-doesnt-describe-idempotent-realtime-publishing branch from 4bfa4c0 to 2c7beb4 Compare September 30, 2024 13:54
@franrob-projects franrob-projects marked this pull request as ready for review September 30, 2024 14:03
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-jrnkre October 2, 2024 15:19 Inactive
@franrob-projects franrob-projects force-pushed the EDU-1469-Idempotent-publishing-doesnt-describe-idempotent-realtime-publishing branch from 02e9a5d to 96ee205 Compare October 2, 2024 15:23
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-1469-idem-jrnkre October 2, 2024 15:23 Inactive
@paddybyers
Copy link
Member

Is there a plan to finish/merge this?

@m-hulbert m-hulbert force-pushed the EDU-1469-Idempotent-publishing-doesnt-describe-idempotent-realtime-publishing branch from 96ee205 to 7c6fb5d Compare April 25, 2025 14:49
Copy link

coderabbitai bot commented Apr 25, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@m-hulbert
Copy link
Contributor

Is there a plan to finish/merge this?

Oops, this was my bad. I split up all the channels section and forgot to go back and sort this out. I've rebased and updated @franrob-projects

@m-hulbert m-hulbert self-assigned this Apr 25, 2025
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-1469-idem-saob76 April 28, 2025 08:59 Inactive
@m-hulbert m-hulbert force-pushed the EDU-1469-Idempotent-publishing-doesnt-describe-idempotent-realtime-publishing branch from 7c6fb5d to 7695c22 Compare May 9, 2025 16:11
@m-hulbert m-hulbert merged commit e12bc17 into main May 9, 2025
6 checks passed
@m-hulbert m-hulbert deleted the EDU-1469-Idempotent-publishing-doesnt-describe-idempotent-realtime-publishing branch May 9, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants